Horton

Re: psql tab-complete

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Victor Spirin <v.spirin@postgrespro.ru>
Cc: pgsql-hackers@lists.postgresql.org
Date: 2019-10-26T03:59:30Z
Lists: pgsql-hackers 
On Fri, Oct 25, 2019 at 11:57:18AM +0300, Victor Spirin wrote:
> This patch resolved one problem in the tab-complete.c on MSVC. The
> VA_ARGS_NARGS macros now work correctly on Windows.

Can you explain why and in what the use of EXPAND() helps with MSVC
builds?  Any references which help to understand why this is better?
If this change is needed, this also surely needs a comment to explain
the difference.
--
Michael

Commits

  1. Add work-around for VA_ARGS_NARGS() on MSVC.