Re: SSL tests failing for channel_binding with OpenSSL <= 1.0.1

Michael Paquier <michael@paquier.xyz>

From: Michael Paquier <michael@paquier.xyz>
To: Jeff Davis <pgsql@j-davis.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Postgres hackers <pgsql-hackers@lists.postgresql.org>
Date: 2019-10-01T00:13:41Z
Lists: pgsql-hackers
On Mon, Sep 30, 2019 at 11:08:20AM -0700, Jeff Davis wrote:
> On Mon, 2019-09-30 at 09:37 -0400, Tom Lane wrote:
>> The committed fix looks odd: isn't the number of executed tests the
>> same in both code paths?  (I didn't try it yet.)
>
> test_connect_fails actually runs two tests, one for the failing exit
> code and one for the error message.

Yes.  The committed code still works as I would expect.  With OpenSSL
<= 1.0.1, I get 10 tests, and 9 with OpenSSL >= 1.0.2.  You can check
the difference from test 5 "SCRAM with SSL and channel_binding=require".
--
Michael

Commits

  1. Fix SSL test for libpq connection parameter channel_binding