Re: REINDEX CONCURRENTLY 2.0

Michael Paquier <michael@paquier.xyz>

From: Michael Paquier <michael@paquier.xyz>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: Sergei Kornilov <sk@zsrv.org>, "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>
Date: 2019-03-26T02:35:10Z
Lists: pgsql-hackers
On Mon, Mar 25, 2019 at 04:23:34PM +0100, Peter Eisentraut wrote:
> Let's do it. :-)

I am pretty sure that this has been said at least once since 2012.

> I've gone over this patch a few more times.  I've read all the
> discussion since 2012 again and made sure all the issues were addressed.
>  I made particularly sure that during the refactoring nothing in CREATE
> INDEX CONCURRENTLY and DROP INDEX CONCURRENTLY was inadvertently
> changed.  I checked all the steps again.  I'm happy with it.

From my side, I would be happy to look at this patch.  Unfortunately I
won't have the room to look at it this week I think :(

But if you are happy with it that's fine by me, at least I can fix
anything which is broken :)
--
Michael

Commits

  1. Prevent reindex of invalid indexes on TOAST tables

  2. Rework handling of invalid indexes with REINDEX CONCURRENTLY

  3. Split builtins.h to a new header ruleutils.h