Horton

Re: Offline enabling/disabling of data checksums

Christoph Berg <myon@debian.org>

View thread View on postgr.es
From: Christoph Berg <myon@debian.org>
To: Fabien COELHO <coelho@cri.ensmp.fr>
Cc: Michael Paquier <michael@paquier.xyz>, Andres Freund <andres@anarazel.de>, Michael Banck <michael.banck@credativ.de>, Magnus Hagander <magnus@hagander.net>, Sergei Kornilov <sk@zsrv.org>, PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
Date: 2019-03-22T15:30:12Z
Lists: pgsql-hackers 
Re: Fabien COELHO 2019-03-22 <alpine.DEB.2.21.1903221514390.2198@lancre>
> Attached is a quick patch about "pg_rewind", so that the control file is
> updated after everything else is committed to disk.

>  	update_controlfile(datadir_target, progname, &ControlFile_new, do_sync);
>  
> -	pg_log(PG_PROGRESS, "syncing target data directory\n");
> -	syncTargetDirectory();

Doesn't the control file still need syncing?

Christoph

Commits

  1. Reorganize Notes section in documentation of pg_checksums

  2. Add option -N/--no-sync to pg_checksums

  3. Add options to enable and disable checksums in pg_checksums

  4. Refactor more code logic to update the control file

  5. Rename pg_verify_checksums to pg_checksums

  6. Fix cross-version compatibility checks of pg_verify_checksums

  7. Add routine able to update the control file to src/common/