Re: Segfault when restoring -Fd dump on current HEAD
Andres Freund <andres@anarazel.de>
From: Andres Freund <andres@anarazel.de>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>, Dmitry Dolgov <9erthalion6@gmail.com>, Michael Paquier <michael@paquier.xyz>, Justin Pryzby <pryzby@telsasoft.com>, Hubert Lubaczewski <depesz@depesz.com>, pgsql-hackers mailing list <pgsql-hackers@postgresql.org>
Date: 2019-03-04T18:32:11Z
Lists: pgsql-hackers
Hi, On 2019-03-04 13:25:40 -0500, Tom Lane wrote: > Andres Freund <andres@anarazel.de> writes: > > One thing I want to bring up here rather than in the pluggable storage > > thread is that currently the pg_dump support for access methods deals > > with table access methods in a manner similar to the way we deal with > > tablespaces. Instead of specifying the AM on every table creation, we > > set the default AM when needed. That makes it easier to adjust dumps. > > Hm. I wonder if it'd make more sense to consider that an access method is > a property of a tablespace? That is, all tables in a tablespace have the > same access method, so you don't need to label tables individually? I don't think that'd work well. That'd basically necessitate creating multiple tablespaces just to create a table with a different AM - creating tablespaces is a superuser only activity that makes backups etc more complicated. It also doesn't correspond well to pg_class.relam etc. > > But it does basically require breaking archive compatibility. I > > personally am OK with that, but I thought it might be worth discussing. > > I don't recall there being huge pushback when we did that in the past, > so I'm fine with it as long as there's an identifiable feature making > it necessary. Cool. Greetings, Andres Freund
Commits
-
pg_dump: store unused attribs as NULL instead of '\0'
- 7fcdb5e00214 12.0 landed
-
pg_dump: Fix ArchiveEntry handling of some empty values
- 19455c9f5606 12.0 landed