Re: get_controlfile() can leak fds in the backend
Andres Freund <andres@anarazel.de>
From: Andres Freund <andres@anarazel.de>
To: Fabien COELHO <coelho@cri.ensmp.fr>
Cc: Michael Paquier <michael@paquier.xyz>, Postgres hackers <pgsql-hackers@lists.postgresql.org>, Joe Conway <mail@joeconway.com>
Date: 2019-02-28T00:50:01Z
Lists: pgsql-hackers
Hi, On 2019-02-27 11:50:17 +0100, Fabien COELHO wrote: > Note that my concern is not about the page size, but rather that as more > commands may change the cluster status by editing the control file, it would > be better that a postmaster does not start while a pg_rewind or enable > checksum or whatever is in progress, and currently there is a possible race > condition between the read and write that can induce an issue, at least > theoretically. Seems odd to bring this up in this thread, it really has nothing to do with the topic. If we were to want to do more here, ISTM the right approach would use the postmaster pid file, not the control file. Greetings, Andres Freund
Commits
-
Tighten use of OpenTransientFile and CloseTransientFile
- 82a5649fb9db 12.0 landed
-
Make get_controlfile not leak file descriptors
- 4598a99cf22d 12.0 landed