Horton

Re: [HACKERS] Time to change pg_regress diffs to unified by default?

Christoph Berg <myon@debian.org>

View thread View on postgr.es
From: Christoph Berg <myon@debian.org>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: Andrew Gierth <andrew@tao11.riddles.org.uk>, Daniel Gustafsson <daniel@yesql.se>, Noah Misch <noah@leadboat.com>, Tom Lane <tgl@sss.pgh.pa.us>, Andres Freund <andres@anarazel.de>, pgsql-hackers@postgresql.org
Date: 2019-02-20T11:47:01Z
Lists: pgsql-hackers 
Re: Peter Eisentraut 2019-02-20 <40c5c12f-adad-fc86-7d43-ff7c535356ed@2ndquadrant.com>
> > By the same argument, it should always print which variant file was
> > used so determining which _N.out files are still in use is possible.
> 
> I would rather not overload the test output even more.  A test passes or
> it doesn't.  If we need to collect additional information, let's think
> about ways to do that separately.

Aye. No objections.

Christoph

Commits

  1. pg_regress: Don't use absolute paths for the diff

  2. Use standard diff separator for regression.diffs