Re: Prepared transaction releasing locks before deregistering its GID

Michael Paquier <michael@paquier.xyz>

From: Michael Paquier <michael@paquier.xyz>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Oleksii Kliukin <alexk@hintbits.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2019-02-19T04:44:45Z
Lists: pgsql-hackers
On Tue, Feb 19, 2019 at 01:07:06AM -0300, Alvaro Herrera wrote:
> On 2019-Feb-19, Michael Paquier wrote:
>>  extern GlobalTransaction MarkAsPreparing(TransactionId xid, const char *gid,
> 
> Hmm, ABI break ...

Well, sure.  I always post patches for HEAD first.  And I was actually
wondering if that's worth back-patching per the odds of facing the
error and seeing how old it is.
--
Michael

Commits

  1. Make release of 2PC identifier and locks consistent in COMMIT PREPARED

  2. Fix incorrect function reference in comment of twophase.c

  3. Add TAP tests for 2PC post-commit callbacks of multixacts at recovery