Horton

Re: [Patch] pg_rewind: options to use restore_command from recovery.conf or command line

Alvaro Herrera <alvherre@2ndquadrant.com>

View thread
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Andres Freund <andres@anarazel.de>
Cc: Alexey Kondratov <a.kondratov@postgrespro.ru>, Andrey Borodin <x4mmm@yandex-team.ru>, PostgreSQL-development <pgsql-hackers@postgresql.org>, Dmitry Dolgov <9erthalion6@gmail.com>, Michael Paquier <michael@paquier.xyz>, vladimirlesk@yandex-team.ru, dsarafan@yandex-team.ru
Date: 2019-02-18T16:49:02Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Move frontend-side archive APIs from src/common/ to src/fe_utils/

  2. Add -c/--restore-target-wal to pg_rewind

  3. Move routine definitions of xlogarchive.c to a new header file

  4. Move routine building restore_command to src/common/

  5. Integrate recovery.conf into postgresql.conf

On 2019-Feb-18, Andres Freund wrote:

> Hi,
> 
> On 2019-02-18 16:26:55 +0300, Alexey Kondratov wrote:
> > Hi Andres,
> > 
> > Thank you for your feedback.
> > 
> > On 16.02.2019 6:41, Andres Freund wrote:
> > > It sounds like a seriously bad idea to use a different parser for
> > > pg_rewind.  Why don't you just use postgres for it? As in
> > > /path/to/postgres -D /path/to/datadir/ -C shared_buffers
> > > ?

Eh, this is what I suggested in this thread four months ago, though I
didn't remember at the time that aaa6e1def292 had already introduced -C
in 2011.  It's definitely the way to go ... all this messing about with
the parser is insane.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services