Re: Incorrect visibility test function assigned to snapshot

Michael Paquier <michael@paquier.xyz>

From: Michael Paquier <michael@paquier.xyz>
To: Antonin Houska <ah@cybertec.at>
Cc: Bruce Momjian <bruce@momjian.us>, Alvaro Herrera <alvherre@2ndquadrant.com>, pgsql-hackers@postgresql.org
Date: 2019-02-18T04:01:20Z
Lists: pgsql-hackers
On Fri, Feb 15, 2019 at 01:01:29PM +0100, Antonin Houska wrote:
> As for the bug fix, I think the additional assignment does not make things
> worse because SnapBuildInitialSnapshot() already does overwrite some fields:
> "xip" and "xnt".

Ah, right.  I somewhat missed that.  Let's move on with merging your
patch then.  Are there any objections about that?
--
Michael

Commits

  1. Mark correctly initial slot snapshots with MVCC type when built