Horton

Re: Progress reporting for pg_verify_checksums

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Michael Banck <michael.banck@credativ.de>
Cc: Fabien COELHO <coelho@cri.ensmp.fr>, Thomas Munro <thomas.munro@enterprisedb.com>, Bernd Helmle <bernd.helmle@credativ.de>, Pg Hackers <pgsql-hackers@postgresql.org>, Alvaro Herrera <alvherre@2ndquadrant.com>
Date: 2019-02-18T03:24:35Z
Lists: pgsql-hackers 
On Sun, Feb 17, 2019 at 09:00:29PM +0100, Michael Banck wrote:
> Well, pg_rewind is also using kB, so should I switch it back to that?

I am not sure which one is better, sorry :)

There is an argument for switching pg_rewind to use MB as well.  I
don't expect pg_rewind to transfer gigs of data, but it could make the
maths harder for a newcomer if it transfers a lot of data.

> It looks like the progress reporting is otherwise quite similar, so what
> exactly did you have in mind?

I was thinking about a routine in src/common/ or such at this time.
The tools have separate goals though, so it looks sensible as well to
keep two routines.  I am fine to let that up to you.
--
Michael

Commits

  1. Add progress reporting to pg_checksums

  2. Fix thinko when bumping on temporary directories in pg_verify_checksums

  3. Fix thinko when bumping on temporary directories in pg_checksums