Re: allow online change primary_conninfo

Michael Paquier <michael@paquier.xyz>

From: Michael Paquier <michael@paquier.xyz>
To: Sergei Kornilov <sk@zsrv.org>
Cc: Andres Freund <andres@anarazel.de>, Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Date: 2019-02-18T03:19:54Z
Lists: pgsql-hackers
On Mon, Feb 18, 2019 at 12:06:05AM +0300, Sergei Kornilov wrote:
> Ok. This was not mentioned before Michael response
> yesterday. restore_command is much faster compared to database
> restart [...]

The startup process would not switch back to streaming with archiving
enabled until it has consumed all the segments available.  I recall
David Steele mentioning me that a perl command invocation can take
easily 100ms.  On a system which generates more than 10 segments per
segment, you can guess what happens..  I think that this argument is a
non-starter if we want to make the WAL receiver a maximum available.

>> That'd still switch to a different method, something we do not want...
> 
> Ok, do not want means we do not want. Will try change behavior.

Thanks Sergei for considering it.  The code paths touched are
sensitive, so we had better be careful here.
--
Michael

Commits

  1. Allow walreceiver configuration to change on reload