Horton
Menu

Re: SQL/JSON: functions

Andres Freund <andres@anarazel.de>

View thread
From: Andres Freund <andres@anarazel.de>
To: Nikita Glukhov <n.gluhov@postgrespro.ru>
Cc: Dmitry Dolgov <9erthalion6@gmail.com>, Pavel Stehule <pavel.stehule@gmail.com>, Oleg Bartunov <obartunov@postgrespro.ru>, PostgreSQL-development <pgsql-hackers@postgresql.org>, Alexander Korotkov <a.korotkov@postgrespro.ru>, Michael Paquier <michael@paquier.xyz>, Simon Riggs <simon@2ndquadrant.com>, Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
Date: 2019-02-16T05:12:39Z
Lists: pgsql-hackers 
Hi,

On 2018-12-05 02:01:19 +0300, Nikita Glukhov wrote:

> +	if (!PG_ARGISNULL(1) &&
> +		strncmp("any", VARDATA(type), VARSIZE_ANY_EXHDR(type)))
> +	{
> +		JsonLexContext *lex;
> +		JsonTokenType tok;
> +
> +		lex = makeJsonLexContext(json, false);
> +
> +		/* Lex exactly one token from the input and check its type. */
> +		PG_TRY();
> +		{
> +			json_lex(lex);
> +		}
> +		PG_CATCH();
> +		{
> +			if (ERRCODE_TO_CATEGORY(geterrcode()) == ERRCODE_DATA_EXCEPTION)
> +			{
> +				FlushErrorState();
> +				MemoryContextSwitchTo(mcxt);
> +				PG_RETURN_BOOL(false);	/* invalid json */
> +			}
> +			PG_RE_THROW();
> +		}
> +		PG_END_TRY();


It baffles me that a year after I raised this as a serious issue, in
this thread, this patch still contains code like this.


Greetings,

Andres Freund

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. JSON_TABLE: Add support for NESTED paths and columns

  2. Add basic JSON_TABLE() functionality

  3. Add SQL/JSON query functions

  4. Add soft error handling to some expression nodes

  5. Adjust populate_record_field() to handle errors softly

  6. Refactor code used by jsonpath executor to fetch variables

  7. Add more SQL/JSON constructor functions

  8. SQL/JSON: support the IS JSON predicate

  9. SQL/JSON: add standard JSON constructor functions

  10. Improve readability of SQL/JSON documentation.

  11. Documentation for SQL/JSON features

  12. RETURNING clause for JSON() and JSON_SCALAR()

  13. SQL JSON functions

  14. SQL/JSON query functions

  15. IS JSON predicate

  16. SQL/JSON constructors

  17. Common SQL/JSON clauses

  18. Doc: remove obsolete entries in table of BRIN strategy numbers.

  19. Doc: standardize markup a bit more.

  20. Make pg_regress.c unset PGDATABASE during make installcheck.

  21. Fix handling of GENERATED columns in CREATE TABLE LIKE INCLUDING DEFAULTS.