Re: Too rigorous assert in reorderbuffer.c

Alvaro Herrera <alvherre@2ndquadrant.com>

View thread View on postgr.es

From: Alvaro Herrera <alvherre@2ndquadrant.com>

To: Arseny Sher <a.sher@postgrespro.ru>

Cc: pgsql-hackers <pgsql-hackers@postgresql.org>, Alexander Lakhin <a.lakhin@postgrespro.ru>

Date: 2019-02-11T18:50:03Z

Lists: pgsql-hackers

Attachments

v3-0001-Remove-assertion-in-reorderbuffer-that-cmax-is-stabl.patch (text/x-diff) patch v3-0001

On 2019-Feb-07, Arseny Sher wrote:

> Alvaro Herrera <alvherre@2ndquadrant.com> writes:

> > Ah, okay.  Does the test still fail when run without the code fix?
> 
> Yes. The problem here is overriding cmax of catalog (pg_attribute in the
> test) tuples, so it fails without any data at all.

Makes sense.

I thought the blanket removal of the assert() was excessive, and we can
relax it instead; what do you think of the attached?

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Commits

Relax overly strict assertion
- f5f9a760a3bc 10.8 landed
- db02c179d7f5 9.6.13 landed
- c2e0954be363 11.3 landed
- 8c67d29fd51c 12.0 landed
- 45ed482f1a89 9.5.17 landed
- 350cdcd5e6dd 9.4.22 landed
Handle heap rewrites even better in logical decoding
- 325f2ec5557f 11.0 cited