Re: Fixing findDependentObjects()'s dependency on scan order (regressions in DROP diagnostic messages)

Alvaro Herrera <alvherre@2ndquadrant.com>

From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Peter Geoghegan <pg@bowt.ie>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2019-02-10T20:47:56Z
Lists: pgsql-hackers
On 2019-Feb-10, Tom Lane wrote:

>        Primary and secondary partition dependencies behave identically
>        except that the primary dependency is preferred for use in error
>        messages; hence, a partition-dependent object should have one
>        primary partition dependency and one or more secondary partition
>        dependencies.

Hmm, zero or more secondary partition dependencies?

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


Commits

  1. Redesign the partition dependency mechanism.

  2. Fix trigger drop procedure

  3. Sort the dependent objects before recursing in findDependentObjects().

  4. Avoid sometimes printing both tables and their columns in DROP CASCADE.