Horton

Re: XLogInsert() of dangling pointer while logging replica identity

Andres Freund <andres@anarazel.de>

View thread View on postgr.es
From: Andres Freund <andres@anarazel.de>
To: Michael Paquier <michael@paquier.xyz>
Cc: Stas Kelvich <s.kelvich@postgrespro.ru>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2019-02-09T11:02:06Z
Lists: pgsql-hackers 
On 2019-02-01 10:38:49 +0900, Michael Paquier wrote:
> On Thu, Jan 31, 2019 at 11:51:36PM +0300, Stas Kelvich wrote:
> >   It seems that heapam.c:3082 calls XLogRegisterData() with an argument
> > allocated on stack, but following call to XLogInsert() happens after
> > end of context for that variable.
> >   Issue spotted by clang's AddressSanitizer. Fix attached.
> 
> Oh, good catch.  Committed and back-patched down to 9.4.

Thanks Stas and Michael!

Commits

  1. Fix use of dangling pointer in heap_delete() when logging replica identity