Horton

Re: [HACKERS] REINDEX CONCURRENTLY 2.0

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: Sergei Kornilov <sk@zsrv.org>, Michael Paquier <michael.paquier@gmail.com>, Andreas Karlsson <andreas@proxel.se>, PostgreSQL mailing lists <pgsql-hackers@postgresql.org>, Stephen Frost <sfrost@snowman.net>, Craig Ringer <craig@2ndquadrant.com>, Alvaro Herrera <alvherre@alvh.no-ip.org>
Date: 2019-02-07T12:18:04Z
Lists: pgsql-hackers 
On Thu, Feb 07, 2019 at 12:49:43PM +0100, Peter Eisentraut wrote:
> Anyway, that's all cosmetics.  Are there any more functional or
> correctness issues to be addressed?

Not that I can think of.  At least this evening.

> Another thing I was thinking of: We need some database-global tests.
> For example, at some point during development, I had broken some variant
> of REINDEX DATABASE.  Where could we put those tests?  Maybe with
> reindexdb?

Having some coverage in the TAP tests of reindexdb is a good idea.
--
Michael

Commits

  1. Prevent reindex of invalid indexes on TOAST tables

  2. Rework handling of invalid indexes with REINDEX CONCURRENTLY

  3. Split builtins.h to a new header ruleutils.h