Re: Add missing CREATE TABLE IF NOT EXISTS table_name AS EXECUTE query;
Michael Paquier <michael@paquier.xyz>
From: Michael Paquier <michael@paquier.xyz>
To: Andreas Karlsson <andreas@proxel.se>
Cc: PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
Date: 2019-02-06T11:49:12Z
Lists: pgsql-hackers
On Wed, Feb 06, 2019 at 03:20:41AM +0100, Andreas Karlsson wrote: > The first example below works while the second one is a syntax error despite > that the documentation > (https://www.postgresql.org/docs/11/sql-createtableas.html) makes it seem > like both should be valid. I do not see any reason to not support CTAS with > both IF NOT EXISTS and EXECUTE at the same time so I am guessing that this > was an oversight. Agreed, good catch. > I have attached a patch which fixes this. What do you think? Should I add a > new test case for this or is the change simple enough to not require any new > test? A test case in select_into.sql would be nice. Should we back-patch that? It seems to me that this qualifies as a bug fix, and I don't see a reason to not support it knowing that we have the infrastructure for that. -- Michael
Commits
-
Fix support for CREATE TABLE IF NOT EXISTS AS EXECUTE
- 06cdab9df413 9.5.17 landed
- d08fae3773ea 9.6.13 landed
- 3a2923a9bfd8 10.8 landed
- 75aba11ec5ed 11.3 landed
- 331a613e9d36 12.0 landed