Re: Tighten up a few overly lax regexes in pg_dump's tap tests
Michael Paquier <michael@paquier.xyz>
From: Michael Paquier <michael@paquier.xyz>
To: David Rowley <david.rowley@2ndquadrant.com>
Cc: Daniel Gustafsson <daniel@yesql.se>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2019-02-06T08:39:43Z
Lists: pgsql-hackers
On Tue, Feb 05, 2019 at 04:26:18PM +0900, Michael Paquier wrote: > On Tue, Feb 05, 2019 at 05:46:55PM +1300, David Rowley wrote: >> I did leave a couple untouched as there was quite a bit of escaping >> going on already. I didn't think switching between \Q and \E would >> have made those ones any more pleasing to the eye. Indeed. I have stuck with your version here. > - qr/^ALTER TABLE dump_test.test_table ENABLE ROW LEVEL SECURITY;/m, > + qr/^\QALTER TABLE dump_test.test_table ENABLE ROW LEVEL SECURITY;/m, > I would have just appended the \E for consistency at the end of the > strings. Except that it looks fine. No need to send an updated > version, it seems that you have all the spots. I'll do an extra pass > on it tomorrow and see if I can commit it. And done after checking the whole set. -- Michael
Commits
-
Align better test output regex with grammar in pg_dump TAP tests
- f339a998ffe6 12.0 landed
-
Tighten some regexes with proper character escaping in pg_dump TAP tests
- d07fb6810e51 12.0 landed