Horton

Re: Log a sample of transactions

Michael Paquier <michael@paquier.xyz>

View thread
From: Michael Paquier <michael@paquier.xyz>
To: Adrien NAYRAT <adrien.nayrat@anayrat.info>
Cc: "Kuroda, Hayato" <kuroda.hayato@jp.fujitsu.com>, "'pgsql-hackers@lists.postgresql.org'" <pgsql-hackers@lists.postgresql.org>
Date: 2019-02-05T03:49:07Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Tweak docs for log_statement_sample_rate

On Mon, Feb 04, 2019 at 04:32:05PM +0100, Adrien NAYRAT wrote:
> Could it be acceptable if I set log_min_duration_statement = 0?

At least this has the merit to make the behavior not rely on
randomness.  I have not looked at the patch in details so I cannot say
for sure, but I am not sure if it is worth the extra cycles to have
tests integrated so they may be removed from the final commit if they
are too expensive for little value.  It is always helpful to have
deterministic tests to give a shot at the feature and ease review of
course.
--
Michael