Re: Variable-length FunctionCallInfoData
Andres Freund <andres@anarazel.de>
From: Andres Freund <andres@anarazel.de>
To: Greg Stark <stark@mit.edu>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2019-01-27T07:13:15Z
Lists: pgsql-hackers
Hi, On 2019-01-27 08:03:17 +0100, Greg Stark wrote: > I assume you already considered and rejected having a fixed size null > bitmap followed by a variable size array of datums. That seems like it > would be denser and work better with cpu cache. It'd be more expensive to access individually (offset calculation + masks, ~5 insn, not fully pipelineable), it'd not guarantee that the null bit and datum are on the same cacheline, you could not pass the null-bit to various functions accepting a bool*, you could not pass the new equivalent NullableDatums to other functions (like both the past and current solution allow). Greetings, Andres Freund
Commits
-
Change function call information to be variable length.
- a9c35cf85ca1 12.0 landed