Horton

Re: Simplify set of flags used by MyXactFlags

Alvaro Herrera <alvherre@2ndquadrant.com>

View thread View on postgr.es
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Date: 2019-01-25T15:30:39Z
Lists: pgsql-hackers 
On 2019-Jan-25, Michael Paquier wrote:

> On Thu, Jan 24, 2019 at 08:56:05AM -0300, Alvaro Herrera wrote:
> > Uh, I didn't think it was necessary nor desirable to rename the flag,
> > only the user-visible message.
> 
> Oh, OK.  I have overstated your comment then.  Are you fine with the
> attached instead?  The flag name remains the same, and the comment is
> updated.

I am, except that the change of "table" to "object" in xact.c line 2262
makes the new paragraph read a bit weird -- it's now saying "if we've
added a temp object ...   Other objects have the same problem".  Doesn't
make sense.  If you keep that word as "table", it works fine.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Commits

  1. Simplify restriction handling of two-phase commit for temporary objects