Re: Simplify set of flags used by MyXactFlags
Alvaro Herrera <alvherre@2ndquadrant.com>
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Date: 2019-01-24T11:56:05Z
Lists: pgsql-hackers
On 2019-Jan-22, Michael Paquier wrote: > On Mon, Jan 21, 2019 at 02:58:39PM -0300, Alvaro Herrera wrote: > > "... operated on temp namespace" doesn't look good; seems to me to be > > missing an article, for one thing, but really I'm not sure that > > 'namespace' is the term to be using here. I'd say "... operated on > > temporary objects" instead (the plural avoids the need for the article; > > and the user doesn't really care about the namespace itself but rather > > about the objects it contains.) > > Thanks for the input. Would you prefer something like the attached > then? I have switched the error message to "temporary objects", and > renamed the flag to XACT_FLAGS_ACCESSEDTEMPOBJECTS. Uh, I didn't think it was necessary nor desirable to rename the flag, only the user-visible message. -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Commits
-
Simplify restriction handling of two-phase commit for temporary objects
- c9b75c5838fe 12.0 landed