Re: [PATCH] Pass COPT and PROFILE to CXXFLAGS as well
Andres Freund <andres@anarazel.de>
From: Andres Freund <andres@anarazel.de>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Michael Paquier <michael@paquier.xyz>, Christoph Berg <christoph.berg@credativ.de>, Peter Eisentraut <peter.eisentraut@2ndquadrant.com>, Tom Lane <tgl@sss.pgh.pa.us>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2019-01-22T20:19:23Z
Lists: pgsql-hackers
Hi, On 2019-01-22 17:10:58 -0300, Alvaro Herrera wrote: > On 2019-Jan-22, Andres Freund wrote: > > > I think its plain wrong to add COPT to CXXFLAGS. Re PROFILE I'm on the > > fence. I personally think the pgxs stuff is a bit separate, and I'm > > doubtful we ought to backpatch that. I'm basically planning to apply > > https://www.postgresql.org/message-id/20190107091734.GA1582%40msg.credativ.de > > to 11-, minus the PGXS stuff. If we want that, we ought to apply it to > > master only IMO. > > I don't understand why you don't want to backpatch the PGXS bits. Largely because I think it's an independent patch from the CXXOPT need from Christopher / Debian packaging. It's a larger patch, that needs more docs etc. If whoever applies that wants to backpatch it - I'm not going to protest, I just wouldn't myself, unless somebody pipes up that it'd help them. Greetings, Andres Freund
Commits
-
Add PG_CFLAGS, PG_CXXFLAGS, and PG_LDFLAGS variables to PGXS
- 42b204db298c 9.4.21 landed
- 12ff406f35b6 9.5.16 landed
- 5e63df82708b 9.6.12 landed
- da14c9b19048 10.7 landed
- 946430da6a0b 11.2 landed
- ac3a9afdbefd 12.0 landed