Horton

Re: should ConstraintRelationId ins/upd cause relcache invals?

Alvaro Herrera <alvherre@2ndquadrant.com>

View thread View on postgr.es
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Pg Hackers <pgsql-hackers@lists.postgresql.org>, Tomas Vondra <tomas.vondra@2ndquadrant.com>
Date: 2019-01-21T22:40:17Z
Lists: pgsql-hackers 
On 2019-Jan-21, Tom Lane wrote:

> Alvaro Herrera <alvherre@2ndquadrant.com> writes:

> > At https://postgr.es/m/201901182216.nr5clsxrn624@alvherre.pgsql I posted
> > a simplistic for the specific problem I found by calling
> > CacheInvalidateRelcache in the problem spot.  But I'm wondering if the
> > correct fix isn't to have CacheInvalidateHeapTuple deal with FK
> > pg_constraint tuples instead, per the attached patch.
> 
> +1, this is safer than expecting retail relcache inval calls to be
> added in all the right places.

Thanks, pushed.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Commits

  1. Flush relcache entries when their FKs are meddled with

  2. Restore foreign-key-aware estimation of join relation sizes.