Re: BUG #15587: Partitions with ALTER TABLE ADD CONSTRAINT
Alvaro Herrera <alvherre@2ndquadrant.com>
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Jesper Pedersen <jesper.pedersen@redhat.com>, pgsql-bugs@lists.postgresql.org
Date: 2019-01-18T18:08:33Z
Lists: pgsql-bugs
On 2019-Jan-17, Alvaro Herrera wrote: > Well, the whole point of my proposal is that the FK-creating code > recurses to partitions by calling ATAddForeignKeyConstraint, and IMO > that's the wrong level to recurse at; we should instead recurse by > calling clone_fk_constraints() as a whole. That's not readibly possible > with the current code arrangement because of layering, but after > backpatching (as attached) the two patches I mentioned, I end up with > the following, which I think is much cleaner. (Also, this code layout > plays much better with my project to continue to extend FKs so that they > are allowed to point to partitioned tables; see the other thread). > > The attached patches are for pg11; they don't apply to master. The > changes are uninteresting. Pushed this. -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Commits
-
Fix creation of duplicate foreign keys on partitions
- 0325d7a5957b 12.0 landed
- 4dff8935fbab 11.2 landed