Horton

Re: [Sender Address Forgery]Re: error message when subscription target is a partitioned table

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>, Magnus Hagander <magnus@hagander.net>, Tatsuo Ishii <ishii@sraoss.co.jp>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2019-01-08T04:44:22Z
Lists: pgsql-hackers 
On Tue, Jan 08, 2019 at 01:13:11PM +0900, Amit Langote wrote:
> Yeah, I think so too.  I also noticed that the patch uses
> ERRCODE_WRONG_OBJECT_TYPE as the error code,  whereas we may want to use
> ERRCODE_FEATURE_NOT_SUPPORTED.  Thoughts on that?

ERRCODE_WRONG_OBJECT_TYPE is the right call I think as the feature is
actually supported, just not for all the object types.

> Attached updated patch, which changes the detail message text as you
> suggest and updates the error code.

Another suggestion I would have is also to change the third message of
CheckSubscriptionRelkind() so as its style maps the two others you are
adding, as what's on HEAD is not a model of its kind with its
formulation using a full sentence.
--
Michael

Commits

  1. Improve error messages for incorrect types of logical replication targets