Horton

Re: Offline enabling/disabling of data checksums

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Michael Banck <michael.banck@credativ.de>
Cc: Magnus Hagander <magnus@hagander.net>, Tomas Vondra <tomas.vondra@2ndquadrant.com>, Postgres hackers <pgsql-hackers@postgresql.org>
Date: 2019-01-01T11:44:19Z
Lists: pgsql-hackers 
On Tue, Jan 01, 2019 at 11:42:49AM +0100, Michael Banck wrote:
> Am Dienstag, den 01.01.2019, 11:38 +0900 schrieb Michael Paquier:
>> About 3), aka --verify implied if no action is specified:
>> - In favor: Fabien C, Magnus
>> - Against: Michael P
> 
> I think I'm in favor as well.

Okay, it looks to be the direction to take then.

> I wonder whether we (or packagers) could then just ship a
> pg_verify_checksums -> pg_checksums symlink for compatibility if we/they
> want, as the behaviour would stay the same?

In the v10 dev cycle this part has been discarded for the switch from
pg_xlogdump to pg_waldump.  I don't think that's worth bothering this
time either in the build.
--
Michael

Commits

  1. Reorganize Notes section in documentation of pg_checksums

  2. Add option -N/--no-sync to pg_checksums

  3. Add options to enable and disable checksums in pg_checksums

  4. Refactor more code logic to update the control file

  5. Rename pg_verify_checksums to pg_checksums

  6. Fix cross-version compatibility checks of pg_verify_checksums

  7. Add routine able to update the control file to src/common/