Re: JIT performance bug/regression & JIT EXPLAIN
Andres Freund <andres@anarazel.de>
From: Andres Freund <andres@anarazel.de>
To: pgsql-hackers@postgresql.org
Date: 2019-09-29T23:30:29Z
Lists: pgsql-hackers
Hi, On 2019-09-27 00:20:53 -0700, Andres Freund wrote: > Unfortunately I found a performance regression for JITed query > compilation introduced in 12, compared to 11. Fixed in one of the > attached patches (v1-0009-Fix-determination-when-tuple-deforming-can-be-JIT.patch > - which needs a better commit message). > > The first question is when to push that fix. I'm inclined to just do so > now - as we still do JITed tuple deforming in most cases, as well as > doing so in 11 in the places this patch fixes, the risk of that seems > low. But I can also see an arguments for waiting after 12.0. Since nobody opined, I now have pushed that, and the other fix mentioned later in that email. I'd appreciate comments on the rest of the email, it's clear that we need to improve the test infrastructure here. And also the explain output for grouping sets... Greetings, Andres Freund
Commits
-
jit: Re-allow JIT compilation of execGrouping.c hashtable comparisons.
- 2ce9bca36458 12.0 landed
- 51ad5b9bd3e3 11.6 landed
- ac88807f9b22 13.0 landed
-
Fix determination when slot types for upper executor nodes are fixed.
- 6cf74f1bbd65 12.0 landed
- 97e971ee05d5 13.0 landed