Horton

Thread

Commits

  1. Remove code relevant to OpenSSL 0.9.6 in be/fe-secure-openssl.c

  1. Cleanup code related to OpenSSL <= 0.9.6 in fe/be-secure-openssl.c

    Michael Paquier <michael@paquier.xyz> — 2019-09-27T03:23:11Z

    Hi all,

While reviewing the area, I have bumped into the following bit in
fe-secure-openssl.c and be-secure-openssl.c:
-        /* OpenSSL 0.96 does not support X509_V_FLAG_CRL_CHECK */
-#ifdef X509_V_FLAG_CRL_CHECK
[...  stuff ...]

I think that this did not get removed because of the incorrect version
number in the comment, which should have been 0.9.6 from the start.

Anyway, let's clean up this code as per the attached.  This set of
flags indeed exists since 0.9.7.  Any thoughts or objections?
--
Michael

  2. Re: Cleanup code related to OpenSSL <= 0.9.6 in fe/be-secure-openssl.c

    Peter Eisentraut <peter.eisentraut@2ndquadrant.com> — 2019-09-27T13:46:09Z

    On 2019-09-27 05:23, Michael Paquier wrote:
> While reviewing the area, I have bumped into the following bit in
> fe-secure-openssl.c and be-secure-openssl.c:
> -        /* OpenSSL 0.96 does not support X509_V_FLAG_CRL_CHECK */
> -#ifdef X509_V_FLAG_CRL_CHECK
> [...  stuff ...]
> 
> I think that this did not get removed because of the incorrect version
> number in the comment, which should have been 0.9.6 from the start.
> 
> Anyway, let's clean up this code as per the attached.  This set of
> flags indeed exists since 0.9.7.  Any thoughts or objections?

Yes, it seems OK to clean this up in master.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

  3. Re: Cleanup code related to OpenSSL <= 0.9.6 in fe/be-secure-openssl.c

    Michael Paquier <michael@paquier.xyz> — 2019-09-28T06:28:15Z

    On Fri, Sep 27, 2019 at 03:46:09PM +0200, Peter Eisentraut wrote:
> Yes, it seems OK to clean this up in master.

Thanks, applied on HEAD.
--
Michael