Horton

Re: [PATCH] Race condition in logical walsender causes long postgresql shutdown delay

Alvaro Herrera <alvherre@2ndquadrant.com>

View thread View on postgr.es
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Jeff Janes <jeff.janes@gmail.com>
Cc: Craig Ringer <craig@2ndquadrant.com>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2019-09-27T01:22:13Z
Lists: pgsql-hackers 
On 2019-Sep-26, Jeff Janes wrote:

> On Wed, Sep 11, 2019 at 3:52 PM Alvaro Herrera <alvherre@2ndquadrant.com>
> wrote:
> 
> > Reading over this code, I noticed that the detection of the catch-up
> > state ends up being duplicate code, so I would rework that function as
> > in the attached patch.
> >
> > The naming of those flags (got_SIGUSR2, got_STOPPING) is terrible, but
> > I'm not going to change that in a backpatchable bug fix.
> 
> Hi Alvaro, does this count as a review?

Well, I'm already a second pair of eyes for Craig's code, so I think it
does :-)  I would have liked confirmation from Craig that my change
looks okay to him too, but maybe we'll have to go without that.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Commits

  1. Fix minor bug in logical-replication walsender shutdown

  2. Prevent possibility of panics during shutdown checkpoint.