Re: PATCH: logical_work_mem and logical streaming of large in-progress transactions
Tomas Vondra <tomas.vondra@2ndquadrant.com>
Commits
GET /api/v1/messages/:b64id/commits
the thread's linked commits as JSON, with link sources.
API reference →
-
Tighten the concurrent abort check during decoding.
- 2ce353fc1902 14.0 landed
-
Improve hash_create()'s API for some added robustness.
- b3817f5f7746 14.0 landed
-
Use HASH_BLOBS for xidhash.
- a1b8aa1e4eec 14.0 landed
-
Fix initialization of RelationSyncEntry for streaming transactions.
- 69bd60672af6 14.0 landed
-
Remove unused function declaration in logicalproto.h.
- ddd5f6d2609b 14.0 landed
-
Add additional tests to test streaming of in-progress transactions.
- 58b5ae9d62bd 14.0 landed
-
Fix inline marking introduced in commit 464824323e.
- ac15b499f7f9 14.0 landed
-
Add support for streaming to built-in logical replication.
- 464824323e57 14.0 landed
-
Fix the SharedFileSetUnregister API.
- 4ab77697f67a 14.0 landed
-
Fix comment in procarray.c
- 77c7267c37f7 14.0 cited
-
Suppress compiler warning in non-cassert builds.
- e942af7b8261 14.0 cited
-
Extend the BufFile interface.
- 808e13b282ef 14.0 landed
-
Mark a few logical decoding related variables with PGDLLIMPORT.
- b48cac3b10a0 14.0 landed
-
Implement streaming mode in ReorderBuffer.
- 7259736a6e5b 14.0 landed
-
Extend the logical decoding output plugin API with stream methods.
- 45fdc9738b36 14.0 landed
-
WAL Log invalidations at command end with wal_level=logical.
- c55040ccd017 14.0 landed
-
Immediately WAL-log subtransaction and top-level XID association.
- 0bead9af484c 14.0 landed
-
Allow logical replication to transfer data in binary format.
- 9de77b545313 14.0 cited
-
Only superuser can set sslcert/sslkey in postgres_fdw user mappings
- cebf9d6e6ee1 13.0 cited
-
Track statistics for spilling of changes from ReorderBuffer.
- 9290ad198b15 13.0 landed
-
Add logical_decoding_work_mem to limit ReorderBuffer memory usage.
- cec2edfa7859 13.0 landed
-
logical decoding: process ASSIGNMENT during snapshot build
- bac2fae05c77 13.0 cited
-
Emit invalidations to standby for transactions without xid.
- c6ff84b06a68 9.6.0 cited
On Thu, Sep 26, 2019 at 04:33:59PM -0300, Alvaro Herrera wrote: >On 2019-Sep-26, Tomas Vondra wrote: > >> Hi, >> >> Attached is an updated patch series, rebased on current master. It does >> fix one memory accounting bug in ReorderBufferToastReplace (the code was >> not properly updating the amount of memory). > >Cool. > >Can we aim to get 0001 pushed during this commitfest, or is that a lost >cause? > It's tempting. The patch has been in the queue for quite a bit of time, and I think it's solid (at least 0001). I'll address the comments from Peter's review about separating the GUC etc. and polish it a bit more. If I manage to do that by Monday, I'll consider pushing it. If anyone feels I shouldn't do that, let me know. The one open question pointed out by Amit is how the patch picks the trasction for eviction. My feeling is that's fine and if needed can be improved later if necessary, but I'll try to construct a worst case (max_connections xacts, each with 64 subxact) to verify. >The large new comment in reorderbuffer.c says that a transaction might >get spilled *or streamed*, but surely that second thing is not correct, >since before the subsequent patches it's not possible to stream >transactions that have not yet finished? > True. That's a residue of reordering the patch series repeatedly, I think. I'll fix that while polishing the patch. regards -- Tomas Vondra http://www.2ndQuadrant.com PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services