Re: PATCH: standby crashed when replay block which truncated in standby but failed to truncate in master node

Michael Paquier <michael@paquier.xyz>

From: Michael Paquier <michael@paquier.xyz>
To: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: tomas.vondra@2ndquadrant.com, thunder1@126.com, pgsql-hackers@lists.postgresql.org
Date: 2019-09-25T03:24:03Z
Lists: pgsql-hackers
On Tue, Sep 24, 2019 at 02:48:16PM +0900, Kyotaro Horiguchi wrote:
> Of course I found no *explicit* ones. But I found one
> ereport(DEBUG1 in register_dirty_segment. So it will work at
> least for the case where fsync request queue is full.

Exactly.  I have not checked the patch in details, but I think that
we should not rely on the assumption that no code paths in this area do
not check after CHECK_FOR_INTERRUPTS() as smgrtruncate() does much
more than just the physical segment truncation.
--
Michael

Commits

  1. Add GUC ignore_invalid_pages.