Re: Attempt to consolidate reading of XLOG page

Alvaro Herrera <alvherre@alvh.no-ip.org>

From: Alvaro Herrera from 2ndQuadrant <alvherre@alvh.no-ip.org>

To: Antonin Houska <ah@cybertec.at>

Cc: Thomas Munro <thomas.munro@gmail.com>, Robert Haas <robertmhaas@gmail.com>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>

Date: 2019-09-23T22:00:38Z

Lists: pgsql-hackers

Attachments

0002-0003.patch (text/x-diff) patch 0002

On 2019-Sep-23, Alvaro Herrera wrote:

> I spent a couple of hours on this patchset today.  I merged 0001 and
> 0002, and decided the result was still messier than I would have liked,
> so I played with it a bit more -- see attached.


-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Commits

Remove logical_read_local_xlog_page
- 5d0c2d5eba6b 13.0 landed
Refactor WAL file-reading code into WALRead()
- 0dc8ead46363 13.0 landed
Rework WAL-reading supporting structs
- 709d003fbd98 13.0 landed
Make XLogReaderInvalReadState static
- 25dcc9d35dfe 13.0 landed
Use pg_pread() and pg_pwrite() for data files and WAL.
- c24dcd0cfd94 12.0 cited