Horton

Re: Add "password_protocol" connection parameter to libpq

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Jeff Davis <pgsql@j-davis.com>
Cc: "Jonathan S. Katz" <jkatz@postgresql.org>, Stephen Frost <sfrost@snowman.net>, Peter Eisentraut <peter.eisentraut@2ndquadrant.com>, pgsql-hackers@postgresql.org
Date: 2019-09-21T02:24:30Z
Lists: pgsql-hackers 
On Fri, Sep 20, 2019 at 10:57:04AM -0700, Jeff Davis wrote:
> Thank you, applied.

Okay, I can see which parts you have changed.

> * I also changed the comment above pg_fe_scram_channel_bound() to
> clarify that the caller must also check that the exchange was
> successful.
> 
> * I changed the error message when AUTH_REQ_OK is received without
> channel binding. It seemed confusing before. I also added a test.

And both make sense.

+ * Return true if channel binding was employed and the scram exchange
upper('scram')?

Except for this nit, it looks good to me.
--
Michael

Commits

  1. Add libpq parameter 'channel_binding'.