Horton

Thread

Commits

  1. Doc: Fix incorrect mention to connection_object in CONNECT command of ECPG

  1. Is it typo of connection_name?

    The Post Office <noreply@postgresql.org> — 2019-09-17T08:39:27Z

    The following documentation comment has been logged on the website:

Page: https://www.postgresql.org/docs/11/ecpg-sql-connect.html
Description:

The "connection_name" parameter's explanation is not in Parameters
section.
Instead of it, "connection_object" parameter is in Parameters section. Its
explanation seems about "connection_name".
Is it typo about "connection_name" in Synopsis section, or
"connection_object" in Parameters section?

  2. Re: Is it typo of connection_name?

    Michael Paquier <michael@paquier.xyz> — 2019-09-18T01:49:14Z

    On Tue, Sep 17, 2019 at 08:39:27AM +0000, PG Doc comments form wrote:
> The "connection_name" parameter's explanation is not in Parameters
> section.
> Instead of it, "connection_object" parameter is in Parameters section. Its
> explanation seems about "connection_name".
> Is it typo about "connection_name" in Synopsis section, or
> "connection_object" in Parameters section?

Good catch.  If you look at the code (ecpg.trailer), connection_object
refers to the name of the parameter, while connection_name refers to
"AS connection_object" as a whole.  So it seems to me that the
intention is to use connection_object in the synopsis of the docs.
Any thoughts from others?
--
Michael

  3. Re: Is it typo of connection_name?

    Michael Paquier <michael@paquier.xyz> — 2019-09-19T04:20:49Z

    On Wed, Sep 18, 2019 at 10:49:14AM +0900, Michael Paquier wrote:
> Good catch.  If you look at the code (ecpg.trailer), connection_object
> refers to the name of the parameter, while connection_name refers to
> "AS connection_object" as a whole.  So it seems to me that the
> intention is to use connection_object in the synopsis of the docs.
> Any thoughts from others?

Actually, looking around we use connection_name for other commands
like EXEC SQL or DISCONNECT, so renaming connection_object to
connection_name makes the documentation more consistent.  And done.
--
Michael

  4. RE: Is it typo of connection_name?

    Egashira, Yusuke <egashira.yusuke@jp.fujitsu.com> — 2019-09-19T09:19:55Z

    Hi Michael

> Actually, looking around we use connection_name for other commands
> like EXEC SQL or DISCONNECT, so renaming connection_object to
> connection_name makes the documentation more consistent.  And done.

Thank you for commiting!

Regards.
Yusuke Egashira