Horton

Re: [PATCH] Speedup truncates of relation forks

Michael Paquier <michael@paquier.xyz>

View thread
From: Michael Paquier <michael@paquier.xyz>
To: "Jamison, Kirk" <k.jamison@jp.fujitsu.com>
Cc: 'Fujii Masao' <masao.fujii@gmail.com>, Alvaro Herrera <alvherre@2ndquadrant.com>, Thomas Munro <thomas.munro@gmail.com>, Masahiko Sawada <sawada.mshk@gmail.com>, "Tsunakawa, Takayuki" <tsunakawa.takay@jp.fujitsu.com>, Tomas Vondra <tomas.vondra@2ndquadrant.com>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>, Adrien Nayrat <adrien.nayrat@anayrat.info>
Date: 2019-09-17T05:25:20Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Speedup truncations of relation forks.

  2. Remove unused smgrdounlinkfork() function.

  3. Accelerate end-of-transaction dropping of relations

On Tue, Sep 17, 2019 at 01:44:12AM +0000, Jamison, Kirk wrote:
> On Friday, September 13, 2019 10:06 PM (GMT+9), Fujii Masao wrote:
>> On Fri, Sep 13, 2019 at 9:51 PM Alvaro Herrera <alvherre@2ndquadrant.com>
>> wrote:
>>>> As committed, the smgrdounlinkfork case is actually dead code; it's
>>>> never called from anywhere.  I left it in place just in case we want
>>>> it someday.
>>>
>>> but if no use has appeared in 7 years, I say it's time to kill it.
>> 
>> +1
> 
> The consensus is we remove it, right?

Yes.  Just adding my +1 to nuke the function.
--
Michael