Re: errbacktrace

Alvaro Herrera <alvherre@2ndquadrant.com>

From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>, Dmitry Dolgov <9erthalion6@gmail.com>, Thomas Munro <thomas.munro@gmail.com>
Date: 2019-09-13T15:54:32Z
Lists: pgsql-hackers

Attachments

On 2019-Aug-20, Peter Eisentraut wrote:

> The memory management of that seems too complicated.  The "extra"
> mechanism of the check/assign hooks only supports one level of malloc.
> Using a List seems impossible.  I don't know if you can safely do a
> malloc-ed array of malloc-ed strings either.

Here's an idea -- have the check/assign hooks create a different
representation, which is a single guc_malloc'ed chunk that is made up of
every function name listed in the GUC, separated by \0.  That can be
scanned at error time comparing the function name with each piece.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Commits

  1. Remove debugging aid