Re: psql - improve test coverage from 41% to 88%

On Thu, Sep 12, 2019 at 12:14:16PM -0300, Alvaro Herrera wrote:
> Mostly, because I think they're going to cause trouble.  Adding a
> parameter in the middle of the list may cause trouble for third-party
> users of TestLib.  I propose that we make the routines a bit smarter to
> cope with the API change: use named parameters instead.  And in order to
> do that without having to change existing users of command_check, make
> it so that the routine checks whether the parameter is a hashref, and
> behave differently.  So when called as in the existing callsites (five
> scalar parameters) it behaves as currently.

+1.
--
Michael