Horton

Re: BUG #15804: Assertion failure when using logging_collector with EXEC_BACKEND

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>, Andres Freund <andres@anarazel.de>, Peter Eisentraut <peter.eisentraut@2ndquadrant.com>, Yuli Khodorkovskiy <yuli.khodorkovskiy@crunchydata.com>, pgsql-bugs@lists.postgresql.org
Date: 2019-09-10T05:39:23Z
Lists: pgsql-bugs 
On Tue, Sep 10, 2019 at 01:28:51AM -0400, Tom Lane wrote:
> But the external PID file is a different story.  I can believe that
> something might be expecting the sockets to be open before we create
> that file --- and since we're not using that file for an interlock,
> there's no reason to be in a hurry to create it.  I think it'd make
> sense to move that step further down, so it's still done after the
> create-sockets step.

That's the actual take here.  We cannot assume that nobody is relying
on that.  If they do, it could be tricky to rework this logic.  Moving
the external file write a bit later does not sound like a bad thing in
itself to keep more consistency with the past.
--
Michael

Commits

  1. Rearrange postmaster's startup sequence for better syslogger results.

  2. Improve logrotate test so that it meaningfully exercises syslogger.

  3. Revert "postmaster: Start syslogger earlier".

  4. postmaster: Start syslogger earlier