Horton

Re: Rearranging ALTER TABLE to avoid multi-operations bugs

Alvaro Herrera <alvherre@2ndquadrant.com>

View thread View on postgr.es
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, movead li <movead.li@highgo.ca>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2019-09-03T16:04:57Z
Lists: pgsql-hackers 
On 2019-Aug-01, Thomas Munro wrote:

> With my hacker hat:  Hmm.  I haven't looked at the patch, but not
> passing down the QueryEnvironment when recursing is probably my fault,
> and folding all such things into a new mechanism that would avoid such
> bugs in the future sounds like a reasonable approach, if potentially
> complicated to back-patch.  I'm hoping to come back and look at this
> properly in a while.

Thomas: Any further input on this?  If I understand you correctly,
you're not saying that there's anything wrong with Tom's patch, just
that you would like to do some further hacking afterwards.

Tom: CFbot says this patch doesn't apply anymore.  Could you please
rebase?  Also: There's further input from Movead; his proposed test
cases might be useful to add.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Commits

  1. Clarify behavior of adding and altering a column in same ALTER command.

  2. Restructure ALTER TABLE execution to fix assorted bugs.

  3. doc: Add best practises section to partitioning docs

  4. Allow on-the-fly capture of DDL event details