Horton

Re: standby recovery fails (tablespace related) (tentative patch and discussion)

Alvaro Herrera <alvherre@2ndquadrant.com>

View thread View on postgr.es
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Anastasia Lubennikova <a.lubennikova@postgrespro.ru>
Cc: Paul Guo <pguo@pivotal.io>, Thomas Munro <thomas.munro@gmail.com>, Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>, PostgreSQL mailing lists <pgsql-hackers@postgresql.org>
Date: 2019-09-03T15:58:55Z
Lists: pgsql-hackers 
On 2019-Aug-22, Anastasia Lubennikova wrote:

> 22.08.2019 16:13, Paul Guo wrote:
> > Thanks. I updated the patch to v5. It passes install-check testing and
> > recovery testing.
> Hi,
> Thank you for working on this fix.
> The overall design of the latest version looks good to me.
> But during the review, I found a bug in the current implementation.
> New behavior must apply to crash-recovery only, now it applies to
> archiveRecovery too.

Hello

Paul, Kyotaro, are you working on updating this bugfix?  FWIW the latest
patch submitted by Paul is still current and CFbot says it passes its
own test, but from Anastasia's email it still needs a bit of work.

Also: it would be good to have this new bogus scenario described by
Anastasia covered by a new TAP test.  Anastasia, can we enlist you to
write that?  Maybe Kyotaro?

Thanks

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Commits

  1. Improve recently-added test reliability

  2. Fix new recovery test for log_error_verbosity=verbose case

  3. Fix test instability

  4. Fix replay of create database records on standby

  5. Allow "in place" tablespaces.

  6. Fix get_dirent_type() for Windows junction points.

  7. Revert "Fix replay of create database records on standby"

  8. Add end-to-end testing of pg_basebackup's tar-format output.

  9. Make DROP DATABASE command generate less WAL records.

  10. Consolidate methods for translating a Perl path to a Windows path.