Horton

Re: BUG #15964: vacuumdb.c:187:10: error: use of undeclared identifier 'FD_SETSIZE'

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andres Freund <andres@anarazel.de>, Alvaro Herrera <alvherre@2ndquadrant.com>, Dilip Kumar <dilipbalaut@gmail.com>, jungleboogie0@gmail.com, pgsql-bugs@lists.postgresql.org
Date: 2019-08-24T02:23:19Z
Lists: pgsql-bugs 
On Fri, Aug 23, 2019 at 10:58:14AM -0400, Tom Lane wrote:
> That seems over-punctuated, plus it burdens the reader with unnecessary
> detail.  Most SQL folk would be confused by the reference to SELECT,
> I bet.  (In fact, don't we have a style guideline against mentioning
> particular syscalls?)
> 
> How about just "too many jobs for this platform -- try %d" ?

WFM.  Do others have any more suggestions?
--
Michael

Commits

  1. Fix error handling of vacuumdb when running out of fds

  2. Fix error handling of vacuumdb and reindexdb when running out of fds

  3. Fix compilation failure of vacuumdb and reindexdb with OpenBSD

  4. Improve Assert output

  5. Refactor parallelization processing code in src/bin/scripts/

  6. vacuumdb: enable parallel mode