Horton

Re: Cleanup isolation specs from unused steps

Alvaro Herrera <alvherre@2ndquadrant.com>

View thread View on postgr.es
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Asim R P <apraveen@pivotal.io>
Cc: Melanie Plageman <melanieplageman@gmail.com>, Michael Paquier <michael@paquier.xyz>, Postgres hackers <pgsql-hackers@lists.postgresql.org>
Date: 2019-08-23T15:38:25Z
Lists: pgsql-hackers 
On 2019-Aug-23, Asim R P wrote:

> As part of the fault injector patch set [1], I added a new "blocking"
> keyword to isolation grammar so that a step can be declared as blocking.
> See patch 0002-Add-syntax-to-declare-a-step-that-is-expected-to-block.

One point to that implementation is that in that design a step is
globally declared to be blocking, but in reality that's the wrong way to
see things: a step might block in some permutations and not others.  So
I think we should do as Michael suggested: it's the permutation that has
to have a way to mark a given step as blocking, not the step itself.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Commits

  1. Detect unused steps in isolation specs and do some cleanup

  2. Remove dry-run mode from isolationtester