Re: BUG #15964: vacuumdb.c:187:10: error: use of undeclared identifier 'FD_SETSIZE'

Michael Paquier <michael@paquier.xyz>

From: Michael Paquier <michael@paquier.xyz>

To: Andres Freund <andres@anarazel.de>

Cc: Alvaro Herrera <alvherre@2ndquadrant.com>, Tom Lane <tgl@sss.pgh.pa.us>, Dilip Kumar <dilipbalaut@gmail.com>, jungleboogie0@gmail.com, pgsql-bugs@lists.postgresql.org

Date: 2019-08-23T01:59:21Z

Lists: pgsql-bugs

On Thu, Aug 22, 2019 at 08:09:45AM -0700, Andres Freund wrote:
> This isn't a particularly general API - it's in
> src/bin/scripts/scripts_parallel.h. So I think a better error message is
> more than worth the slight decrease in generality.

The latest patch does that:
+    pg_log_fatal("too many jobs for this platform's select() -- try %d"
Do you have a better suggestion to offer, like a s#jobs#-j/--jobs#?
--
Michael

Commits

Fix error handling of vacuumdb when running out of fds
- a21ec1a959ef 9.5.20 landed
- eb91b8ee6572 9.6.16 landed
- 4fca1460099e 10.11 landed
- 5d76c8037329 11.6 landed
- 63fc3b124008 12.0 landed
Fix error handling of vacuumdb and reindexdb when running out of fds
- 71d84efba714 13.0 landed
Fix compilation failure of vacuumdb and reindexdb with OpenBSD
- 56f8f9624ba0 13.0 landed
Improve Assert output
- d78d452bc5ac 13.0 cited
Refactor parallelization processing code in src/bin/scripts/
- 5f3840370b63 13.0 cited
vacuumdb: enable parallel mode
- a17923204736 9.5.0 cited