Horton

Re: BUG #15964: vacuumdb.c:187:10: error: use of undeclared identifier 'FD_SETSIZE'

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Andres Freund <andres@anarazel.de>, Dilip Kumar <dilipbalaut@gmail.com>, jungleboogie0@gmail.com, pgsql-bugs@lists.postgresql.org
Date: 2019-08-22T01:47:39Z
Lists: pgsql-bugs

Attachments

On Wed, Aug 21, 2019 at 10:34:49AM -0400, Alvaro Herrera wrote:
> Ah, yes, that's right -- my system's open(3p) manpage says:
> 
>        The  open()  function  shall return a file descriptor for the named file
>        that is the lowest file descriptor not currently open for that process.

Ah, well.  In this case, what about that?
("too many jobs for this platform's select() -- try %d", i-1)

I don't think that it is a good idea to use the option name -j/--jobs
directly in the error string as scripts_parallel.c should not have any
knowledge of how the option layer is in the tools using its APIs.
Attached is an updated patch, with refined comments.
--
Michael

Commits

  1. Fix error handling of vacuumdb when running out of fds

  2. Fix error handling of vacuumdb and reindexdb when running out of fds

  3. Fix compilation failure of vacuumdb and reindexdb with OpenBSD

  4. Improve Assert output

  5. Refactor parallelization processing code in src/bin/scripts/

  6. vacuumdb: enable parallel mode