Horton

Re: Cleanup isolation specs from unused steps

Alvaro Herrera <alvherre@2ndquadrant.com>

View thread View on postgr.es
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Melanie Plageman <melanieplageman@gmail.com>, Postgres hackers <pgsql-hackers@lists.postgresql.org>
Date: 2019-08-20T04:34:45Z
Lists: pgsql-hackers 
On 2019-Aug-20, Michael Paquier wrote:

> On Mon, Aug 19, 2019 at 10:23:19AM -0700, Melanie Plageman wrote:
> > Could you do the check that all steps have been used in dry_run mode
> > instead of when running the tests for real?
> 
> Sure, I was hesitating to do so.  I have no issue in moving the check
> into run_testspec().  So done as attached.

I created the dry-run mode to be able to easily generate the set of
possible permutations for a new test, then edit the result and put it
back in the spec file; but after the deadlock tests were added (with
necessary hacking of the lock-detection in isolationtester) that manner
of operation became almost completely useless.  Maybe we need to rethink
what facilities isolationtester offers -- possibly making dry-run have a
completely different behavior than currently, which I doubt anybody is
using.

All that being said, I have no objections to this patch (but I didn't
review it closely).

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Commits

  1. Detect unused steps in isolation specs and do some cleanup

  2. Remove dry-run mode from isolationtester