Horton

Re: Unused header file inclusion

Alvaro Herrera <alvherre@2ndquadrant.com>

View thread View on postgr.es
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Andres Freund <andres@anarazel.de>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, vignesh C <vignesh21@gmail.com>, Pg Hackers <pgsql-hackers@postgresql.org>
Date: 2019-08-19T21:18:19Z
Lists: pgsql-hackers 
On 2019-Aug-19, Andres Freund wrote:

> > I wish we could move the whole logic of those scripts into makefiles, so
> > we could employ parallelism.
> 
> Hm. Perhaps the way to do that would be to use gcc's -include to include
> postgres.h, and use -Wc++-compat to detect c++ issues, rather than using
> g++. Without tempfiles it ought to be a lot easier to just do all of the
> relevant work in make, without a separate shell script.

I used to have this:
https://postgr.es/m/1293469595-sup-1462@alvh.no-ip.org
Not sure how much this helps, since it's a shell line in make, so not
very paralellizable.  And you still have to build the exclusions
somehow.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Commits

  1. Add fmgr.h include to selfuncs.h.

  2. Add "headerscheck" script to test header-file compilability under C.

  3. Fix failure-to-compile-standalone in scripts_parallel.h.

  4. Remove fmgr.h includes from headers that don't really need it.

  5. Don't include utils/array.h from acl.h.

  6. Remove redundant prototypes for SQL callable functions.

  7. Remove unnecessary #include <limits.h>

  8. Teach tuplesort.c about "top N" sorting, in which only the first N tuples