Horton

Re: Unused header file inclusion

Alvaro Herrera <alvherre@2ndquadrant.com>

View thread View on postgr.es
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andres Freund <andres@anarazel.de>, vignesh C <vignesh21@gmail.com>, Pg Hackers <pgsql-hackers@postgresql.org>
Date: 2019-08-19T14:22:14Z
Lists: pgsql-hackers 
On 2019-Aug-18, Tom Lane wrote:

> I wrote:
> > (My headerscheck script is missing that header; I need to update it to
> > match the latest version of cpluspluscheck.)
> 
> I did that, and ended up with the attached.  I'm rather tempted to stick
> this into src/tools/ alongside cpluspluscheck, because it seems to find
> rather different trouble spots than cpluspluscheck does.  Thoughts?

Yeah, let's include this.  I've written its equivalent a couple of times
already.  (My strategy is just to compile the .h file directly though,
which creates a .gch file, rather than writing a temp .c file.)


-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Commits

  1. Add fmgr.h include to selfuncs.h.

  2. Add "headerscheck" script to test header-file compilability under C.

  3. Fix failure-to-compile-standalone in scripts_parallel.h.

  4. Remove fmgr.h includes from headers that don't really need it.

  5. Don't include utils/array.h from acl.h.

  6. Remove redundant prototypes for SQL callable functions.

  7. Remove unnecessary #include <limits.h>

  8. Teach tuplesort.c about "top N" sorting, in which only the first N tuples