Horton

Cleanup isolation specs from unused steps

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Date: 2019-08-19T08:08:20Z
Lists: pgsql-hackers

Attachments

Hi all,

I have been looking at the isolation tests, and we have in some specs
steps which are defined but not used in any permutations.  In order to
detect them, I have been using the attached trick to track which
permutations are used.  This allows to find immediately any
over-engineered spec by generating diffs about steps defined by not
used in any permutations.  On HEAD, we have six specs entering in this
category.

Would that be useful?
--
Michael

Commits

  1. Detect unused steps in isolation specs and do some cleanup

  2. Remove dry-run mode from isolationtester